[data.indexPatterns] Fix broken rollup index pattern creation #76593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
regression
Feature:Data Views
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
3 tasks
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Sep 3, 2020
lukeelmers
added a commit
that referenced
this pull request
Sep 3, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 3, 2020
* master: (340 commits) [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943) [release notes] automatically retry on Github API 5xx errors (elastic#76447) [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392) [i18n] Integrate 7.9.1 Translations (elastic#76391) [APM] Update aggregations to support script sources (elastic#76429) [Security Solution] Refactor Network Top Countries to use Search Strategy (elastic#76244) Document security settings available on ESS (elastic#76513) [Ingest Manager] Add input revision to the config send to the agent (elastic#76327) [DOCS] Identifies cloud settings for Monitoring (elastic#76579) [DOCS] Identifies Cloud settings in Dev Tools (elastic#76583) [Ingest Manager] Better default value for fleet long polling timeout (elastic#76393) [data.indexPatterns] Fix broken rollup index pattern creation (elastic#76593) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating rollup-based index patterns is currently broken: the
_fetch_fields_for_wildcardroute returns a 400 due to a missingrollup_indexparam. Rollup index patterns are successfully created, but fields are unable to be retrieved, making them useless in most scenarios.Surprisingly, it was a result of this small PR: #76004
It turns out that the
typeMeta-- which is the extension point used by rollups to customize index pattern behavior -- was accidentally serialized as the index patternmappinginstead of the actualtypeMeta:kibana/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts
Line 444 in e88470d
The missing
typeMetaresulted in an improperly formatted saved index pattern object, which ultimately didn’t send the correct parameters when looking up fields on the rollup index as it couldn't read the meta it needed.If you're like me, you are probably wondering, "hey, why don't we have a functional test for this case?" The answer to that question is, we do. But unfortunately, it didn't have any assertions to ensure the newly-created rollup index pattern could actually be retrieved. As a result, the test runner had no idea the error was even happening.
This PR fixes the typo, and also updates the functional test to ensure that (A) No toasts appear after index pattern creation, which might indicate an error; and (B) The expected fields for the new index pattern are displayed in the UI.
Unblocks #75943